Tag: php

im reading clean code, and practicing SOLID principles, can someone help me to improve this code, suggestions are welcome:

<?php 

require_once ('database.class.php');

class EncryptPassword{
    
    public function encrypt(string $password){
        $encrypted_password = sha1($password);
        return $encrypted_password;
    }

}

class insertUser extends EncryptPassword{

    private $id_user_type;
    private $name;
    private $lastname;
    private $email;
    private $password;
    

    public function __construct(int $id_user_type, string $name, string $lastname, string $email, string $password){

        $this->id_user_type = $id_user_type;
        $this->name = $name;
        $this->lastname = $lastname;
        $this->email = $email;
        $this->password = $password;
        
    }

    public function insert(){

        try {

            $db = database::getInstance();

            $password = parent::encrypt($this->password);

            $sql = $db->prepare("INSERT INTO users (id_user_type, name, lastname, email, password) VALUES (?, ?, ?, ?, ?)");

            $sql->bindParam(1, $this->id_user_type);
            $sql->bindParam(2, $this->name);
            $sql->bindParam(3, $this->lastname);
            $sql->bindParam(4, $this->email);
            $sql->bindParam(5, $password);

            $result = $sql->execute();

            if($result==true){
                return "inserted";
            } else {
                return "not inserted";
            }

        } catch (Exception $e) {
            print $e->getMessage();        
        }

    }

}

class updateUser extends EncryptPassword{

    private $id_user;
    private $id_user_type;
    private $name;
    private $lastname;
    private $email;
    private $password;
    

    public function __construct(int $id_user, int $id_user_type, string $name, string $lastname, string $email, string $password=''){

        $this->id_user = $id_user;
        $this->id_user_type = $id_user_type;
        $this->name = $name;
        $this->lastname = $lastname;
        $this->email = $email;
        $this->password = $password;
        
    }

    public function update(){

        try {

            $db = database::getInstance();
            $password = parent::encrypt($this->password);

            if(!empty($password)){

                $sql = "UPDATE users SET id_user_type=?, name=?, lastname=?, email=?, password=? WHERE id=?";
                $stmt= $db->prepare($sql);
                $result = $stmt->execute(($this->id_user_type, $this->name, $this->lastname, $this->email, $password, $this->id_user));
                
            } else {

                $sql = "UPDATE users SET id_user_type=?, name=?, lastname=?, email=? WHERE id=?";
                $stmt= $db->prepare($sql);
                $result = $stmt->execute(($this->id_user_type, $this->name, $this->lastname, $this->email, $this->id_user));
                
            }

            if($result==true){
                return "updated";
            } else {
                return "not updated";
            }

        
        } catch (Exception $e) {
            print $e->getMessage();        
        }

    }

}


class getUsers{

    public function getAllUsers(){

        try {

            $db = database::getInstance();

            $sql = 'SELECT id, name, lastname, email, active, date FROM users';
            $stm = $db->prepare($sql);
            $stm->execute();
            $result = $stm->fetchAll(PDO::FETCH_ASSOC);

            return $result;
        
        } catch (Exception $e) {
            print $e->getMessage();        
        }

    }

}

class getUserInfo{

    public function __construct(int $id_user){
        $this->id_user = $id_user;
    }

    public function getUser(){

        try {

            $db = database::getInstance();

            $sql = "SELECT id, name, lastname, email, active, date FROM users where id=:id";
            $stm = $db->prepare($sql);
            $stm->bindParam(':id', $this->id_user, PDO::PARAM_INT);
            $stm->execute();
            $result = $stm->fetch();

            return $result;
        
        } catch (Exception $e) {
            print $e->getMessage();        
        }

    }

}

class OnOff{

    public function __construct(int $id_user, int $actdeact){
        $this->id_user = $id_user;
        $this->actdeact = $actdeact;
    }

    public function statusUser(){

        try {

            $db = database::getInstance();

            $sql = "UPDATE users SET active=? WHERE id=?";
            $stmt= $db->prepare($sql);
            $result = $stmt->execute(($this->actdeact, $this->id_user));

            return $result;
        
        } catch (Exception $e) {
            print $e->getMessage();        
        }

    }

}

The database class:

<?php

class database {

    protected static $instance;

    protected function __construct() {}

    public static function getInstance() {

        if(empty(self::$instance)) {

            $db_info = array(
                "db_host" => "localhost",
                "db_port" => "3306",
                "db_user" => "localhost",
                "db_pass" => "xxxxxxxxxx",
                "db_name" => "xxxxxxxxxx",
                "db_charset" => "UTF-8");

            try {

                self::$instance = new PDO("mysql:host=".$db_info('db_host').';port='.$db_info('db_port').';dbname='.$db_info('db_name'), $db_info('db_user'), $db_info('db_pass'));
                self::$instance->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_SILENT);  
                self::$instance->query('SET NAMES utf8');
                self::$instance->query('SET CHARACTER SET utf8');

            } catch(PDOException $error) {
                echo $error->getMessage();
            }

        }
        return self::$instance;
    }
}

?>