Tag: php

I don't program PHP too often. I wanted to write a bbc code analyzer for my forums. What do you see that could be improved?

You can see the code live here: https://joshuad.net/misc/dice-test.php

Syntax

Basic Rolls: NdM: Roll N dice with M sides. i.e. 3d20 rolls three twenty sided dice.
Add Modifiers: 1d20+1 or 1d20-5: Add (or subtract) the indicated amount from the roll
Reroll Low Results: 1d20r3: Roll 1d20, but keep re-rolling if the result is 3 or lower.
Keep Highest Rolls: 4d6^3: Roll 4d6, but keep only the 3 highest results, discarding the remainder.
Keep Lowest Rolls: 4d6v3: Roll 4d6, but keep only the 3 lowest results, discarding the remainder.
Note: You cannot have ^ and v in the same roll -- 3d6^1v1 is invalid.
Compound Rolls are OK: 3d6-2d6-5+3: Roll 3d6, subtract 2d6, subtract 5, add 3
Whitespace is ignored:  1 d 6 and 1d6 are the same thing. '1 d 2 0' will work too, all white space
is completely ignored
Syntax Errors Any syntax errors cause the entire roll to be considered invalid.

Tests

";
   }
?>



= 2 && $capture(1)) ? $capture(1) : 0;
            preg_match('/v(d+)/', $rollToken, $capture);
            $keepLowCount = (sizeof($capture) >= 2 && $capture(1)) ? $capture(1) : 0;
            preg_match('/^(d+)/', $rollToken, $capture);
            $keepHighCount = (sizeof($capture) >= 2 && $capture(1)) ? $capture(1) : 0;
            $detailText .= (empty($detailText) ? "" : "
") . "" . ($rollSign == -1 ? "-" : "") . "$rollToken Results: ";
            $subTotal = 0;
            $rollResults = array();
            if ($rerollThreshold >= $diceType) {
              $detailText = $INVALID_ROLL_ERROR;
              break;  //Future note: This should break out of the big foreach ($rollTokens) loop
            }
            for ($k = 0; $k < $numberOfDice; $k++) {
              array_push ($rollResults, rand($rerollThreshold+1, $diceType));
            }
            if ($keepHighCount > 0 || $keepLowCount > 0) {
               if ($keepHighCount > 0) {
                  $keepCount = $keepHighCount;
                  $selectorFunction = "max";
               } else {
                  $keepCount = $keepLowCount;
                  $selectorFunction = "min";
               }
               if ($keepCount > $numberOfDice) {
                  $detailText = $INVALID_ROLL_ERROR;
                  break;  //Future note: This should break out of the big foreach ($rollTokens) loop
               }
               $keep = array();
               $discard = array();
               foreach ($rollResults as $key => $val) {
                 $discard($key) = $val;
               }
               for ($k = 0; $k < $keepCount; $k++) {
                  $highest = call_user_func($selectorFunction, $discard);
                  $highestIndex = array_search($highest, $discard);
                  array_push($keep, $highest);
                  unset($discard($highestIndex));
               }
               foreach ($rollResults as $roll) {
                  $keepIndex = array_search($roll, $keep);
                  $discardIndex = array_search($roll, $discard);
                  if ($keepIndex !== False) {
                     $detailText .= "$roll ";
                     $subTotal += $roll;
                     unset($keep($keepIndex));
                  } else {
                     $detailText .= "$roll ";
                     unset($discard($discardIndex));
                  }
               }
            } else {
               foreach ($rollResults as $rollResult) {
                  $detailText .= "$rollResult ";
                  $subTotal += $rollResult;
               }
            }
            $subTotal *= $rollSign;
            $detailText .= " (Total = $subTotal)";
            $rollTotal += $subTotal;
         }
      }
   } else {
      $detailText = $INVALID_ROLL_ERROR;
      $rollTotal = "0";
   }
   $detailText .= "
Total: " . $rollTotal;
   $detailText = "Dice Roll: " . $inputClean . "
$detailText";
   return array('input'=>$inputText, 'total'=>$rollTotal, 'detailText'=>$detailText);
}
?>